Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate suggestions for 2.6.0 #326

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Incorporate suggestions for 2.6.0 #326

merged 7 commits into from
Jun 17, 2024

Conversation

jonasscheid
Copy link
Collaborator

@jonasscheid jonasscheid commented Jun 15, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mhcquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 15, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5bfb1d9

+| ✅ 234 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-17 07:09:21

SPPearce
SPPearce reviewed Jun 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
modules/local/openms_featurefinderidentification.nf Outdated Show resolved Hide resolved
modules/local/openms_cometadapter.nf Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@jonasscheid jonasscheid merged commit 722343b into nf-core:dev Jun 17, 2024
8 checks passed
@jonasscheid
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasscheid @SPPearce